Fix 431/checkbox initial checked #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #431
馃摑 Description
Checkbox's
initialCheckedprop was being passed to the html鉀筹笍 Current behavior (updates)
React doesn't recognize the
initialCheckedprop on a DOM element馃殌 New behavior
The
initialCheckedprop was taken out from the checkboxProps, this prop will be renamed todefaultSelectedin a near future馃挘 Is this a breaking change (Yes/No): No
馃摑 Additional Information
The
initialCheckedwill be renamed todefaultSelectedin a near future to have a better@react-ariaintegration