Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-user): prop and link warnings #466

Merged
merged 2 commits into from Jun 6, 2022
Merged

fix(react-user): prop and link warnings #466

merged 2 commits into from Jun 6, 2022

Conversation

tianenpang
Copy link
Member

@tianenpang tianenpang commented May 10, 2022

Closes #474

馃摑 Description

  • passed unnecessary props to StyledUser

Warning: Received true for a non-boolean attribute zoomed
Warning: Received true for a non-boolean attribute pointer

  • StyledUserLink and Link both use the a tag

Warning: validateDOMNesting(...): <a> cannot appear as a descendant of <a>

鉀筹笍 Current behavior (updates)

  • structure props in order to pass the correct otherProps

  • change the a tag of StyledUserLink to span

馃挘 Is this a breaking change (Yes/No):

No

@codecov-commenter
Copy link

Codecov Report

Merging #466 (b1b2c35) into main (777a006) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #466   +/-   ##
=======================================
  Coverage   74.95%   74.95%           
=======================================
  Files         183      183           
  Lines        2831     2831           
  Branches      843      843           
=======================================
  Hits         2122     2122           
  Misses        698      698           
  Partials       11       11           
Impacted Files Coverage 螖
packages/react/src/user/user.tsx 100.00% <酶> (酶)
packages/react/src/user/user.styles.ts 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 777a006...b1b2c35. Read the comment docs.

@tianenpang tianenpang changed the title fix: user prop and user link warnings fix(react-user): prop and link warnings May 10, 2022
@jrgarciadev jrgarciadev added this to the 馃殌 v1.0.0-beta.8 milestone May 16, 2022
packages/react/src/user/user.styles.ts Outdated Show resolved Hide resolved
packages/react/src/user/user.styles.ts Outdated Show resolved Hide resolved
@jrgarciadev
Copy link
Member

Huge thanks! @tianenpang 馃檹馃徎

@jrgarciadev jrgarciadev changed the base branch from main to next June 6, 2022 18:00
@jrgarciadev jrgarciadev merged commit 5eee8a9 into nextui-org:next Jun 6, 2022
@tianenpang tianenpang deleted the fix/user-prop-tag branch December 21, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Received true for a non-boolean attribute
4 participants