Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs-landing): confetti position #469

Merged
merged 4 commits into from May 13, 2022
Merged

fix(docs-landing): confetti position #469

merged 4 commits into from May 13, 2022

Conversation

tianenpang
Copy link
Member

@tianenpang tianenpang commented May 12, 2022

Closes #468

馃摑 Description

Fix the confetti position in the landing page.

鉀筹笍 Current behavior (updates)

Correct the confetti position by click event.

Remove the confetti positioning code from example and focus on the topic.

馃挘 Is this a breaking change (Yes/No):

No

馃摑 Additional Information

Screenshot of confetti with better position

confetti-postion-screenshot

@tianenpang tianenpang changed the title feat(docs-landing): confetti position fix(docs-landing): confetti position May 12, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2022

Codecov Report

Merging #469 (47fc75e) into main (014e36e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #469   +/-   ##
=======================================
  Coverage   74.95%   74.95%           
=======================================
  Files         183      183           
  Lines        2831     2831           
  Branches      843      843           
=======================================
  Hits         2122     2122           
  Misses        698      698           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 014e36e...47fc75e. Read the comment docs.

@tianenpang
Copy link
Member Author

Remove confetti comments, and better x position for confetti by clientWidth.

@tianenpang
Copy link
Member Author

Additional fix for missing key of initial style elements in _document.tsx using React.Children.toArray

Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tianenpang 馃檹馃徎

@jrgarciadev jrgarciadev merged commit 669e185 into nextui-org:main May 13, 2022
@tianenpang tianenpang deleted the fix/confetti-position branch December 21, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - confetti works in wrong position
4 participants