Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): theme toggle with nextui #492

Merged
merged 1 commit into from May 26, 2022
Merged

feat(storybook): theme toggle with nextui #492

merged 1 commit into from May 26, 2022

Conversation

tianenpang
Copy link
Member

@tianenpang tianenpang commented May 26, 2022

馃摑 Description

Storybook theme switching with NextUI.

鉀筹笍 Current behavior (updates)

  • Fullscreen canvas
  • Correct the theme class
  • Use NextUI radii xs
  • Use NextUI color accents

馃挘 Is this a breaking change (Yes/No):

No

馃摑 Additional Information

Screenshot of light theme

light

Screenshot of dark theme

dark

@codecov-commenter
Copy link

Codecov Report

Merging #492 (f4aedc4) into main (3aa92a9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #492   +/-   ##
=======================================
  Coverage   74.95%   74.95%           
=======================================
  Files         183      183           
  Lines        2831     2831           
  Branches      843      843           
=======================================
  Hits         2122     2122           
  Misses        698      698           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3aa92a9...f4aedc4. Read the comment docs.

@jrgarciadev jrgarciadev changed the base branch from main to next May 26, 2022 12:47
Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks! @tianenpang 馃檹馃徎

@jrgarciadev jrgarciadev merged commit 3e397e8 into nextui-org:next May 26, 2022
@tianenpang tianenpang deleted the feat/storybook-theme-toggle branch December 21, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants