Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit node version to make Storybook work properly (fix #498) #499

Merged
merged 1 commit into from Jun 6, 2022

Conversation

imchell
Copy link
Contributor

@imchell imchell commented May 27, 2022

Closes #

馃摑 Description

The problem was described in #498.

鉀筹笍 Current behavior (updates)

Let users develop NextUI with Node >=12.13.0 and <18.0.0.

馃殌 New behavior

Now it would prevent users to develop with Node 18 and make sure Storybook launch successfully.

馃挘 Is this a breaking change (Yes/No): No

馃摑 Additional Information

@imchell imchell requested a review from jrgarciadev as a code owner May 27, 2022 16:13
@jrgarciadev jrgarciadev changed the base branch from main to next June 6, 2022 13:15
@jrgarciadev
Copy link
Member

Thanks! @imchell

@jrgarciadev jrgarciadev merged commit 97982ef into nextui-org:next Jun 6, 2022
@jrgarciadev jrgarciadev linked an issue Jun 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Storybook not launch when node >= 18
2 participants