Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: card text selection #520

Merged
merged 1 commit into from Jun 9, 2022
Merged

fix: card text selection #520

merged 1 commit into from Jun 9, 2022

Conversation

imchell
Copy link
Contributor

@imchell imchell commented Jun 8, 2022

馃摑 Description

Texts on card components can not be selected by mouse when they are not pressable.

鉀筹笍 Current behavior (updates)

Texts can not be selected nor copied.

馃殌 New behavior

Texts can be selected and copied.

馃挘 Is this a breaking change (Yes/No): No

馃摑 Additional Information

This is a bug invoked by react-aria usePress. According to the author of usePress() (explained here, which also involved the card implementation), we should avoid it when the card is not pressable. Correct me if I'm wrong 馃槀 not a pro of react-aria

@imchell imchell requested a review from jrgarciadev as a code owner June 8, 2022 16:34
@codecov-commenter
Copy link

Codecov Report

Merging #520 (015fd12) into main (aa7c285) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   74.75%   74.78%   +0.02%     
==========================================
  Files         200      200              
  Lines        3090     3093       +3     
  Branches      952      955       +3     
==========================================
+ Hits         2310     2313       +3     
  Misses        765      765              
  Partials       15       15              
Impacted Files Coverage 螖
packages/react/src/card/card.tsx 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update aa7c285...015fd12. Read the comment docs.

@jrgarciadev jrgarciadev changed the base branch from main to next June 8, 2022 17:49
Copy link
Member

@jrgarciadev jrgarciadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @imchell 馃檹馃徎

@jrgarciadev jrgarciadev merged commit bb17417 into nextui-org:next Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants