Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0-beta.9 #533

Merged
merged 14 commits into from Jun 9, 2022
Merged

v1.0.0-beta.9 #533

merged 14 commits into from Jun 9, 2022

Conversation

jrgarciadev
Copy link
Member

@jrgarciadev jrgarciadev commented Jun 9, 2022

Closes #401
Closes #522

🚀 New behavior

  • feat: React v18 support
  • fix: Card ids mismatch issue
  • fix: Card internal components hover and text copy
  • feat: Card new prop allowTextSelectionOnPress added to control whether text selection should be enabled on the pressable element.
  • fix: Dropdown trigger ref forwarded
  • fix: Press props are now being passed to the button

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No): No

📝 Additional Information

@codecov-commenter
Copy link

Codecov Report

Merging #533 (741dfbc) into main (d3c7f53) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #533      +/-   ##
==========================================
+ Coverage   74.75%   74.82%   +0.06%     
==========================================
  Files         200      200              
  Lines        3090     3098       +8     
  Branches      952      956       +4     
==========================================
+ Hits         2310     2318       +8     
  Misses        765      765              
  Partials       15       15              
Impacted Files Coverage Δ
packages/react/src/button/button.tsx 94.00% <ø> (ø)
packages/react/src/card/card.tsx 100.00% <ø> (ø)
packages/react/src/popover/index.ts 100.00% <ø> (ø)
packages/react/src/popover/popover.tsx 100.00% <ø> (ø)
packages/react/src/card/use-card.ts 70.58% <100.00%> (+6.30%) ⬆️
packages/react/src/dropdown/dropdown-trigger.tsx 100.00% <100.00%> (ø)
packages/react/src/popover/popover-content.tsx 80.95% <100.00%> (ø)
packages/react/src/popover/popover-trigger.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c7f53...741dfbc. Read the comment docs.

@jrgarciadev jrgarciadev merged commit c54c84c into main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants