Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken broken_link checker (too noisy 馃槥) #1217

Merged
merged 1 commit into from Aug 2, 2022

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Aug 1, 2022

I guess it is time to say good-bye 馃憢馃徎

@mashehu mashehu requested a review from ewels August 1, 2022 13:24
@mashehu mashehu changed the title remove broken_link checker (too noisy 馃槥) remove broken broken_link checker (too noisy 馃槥) Aug 1, 2022
@ewels
Copy link
Member

ewels commented Aug 1, 2022

Can always add it back again if / when gaurav-nelson/github-action-markdown-link-check#121 is implemented.

Could also look into implementing that as a PR. I actually don't think it should be all that difficult to do. Mostly redirecting the output from the npm markdown-link-check package to /dev/null and then giving a nicer output when printing from errors.txt. It's a fairly short entrypoint.sh script in the action.

@ewels ewels merged commit 7473083 into nf-core:master Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants