Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates react-fast-compare to get support for Preact #559

Merged

Conversation

esbenam
Copy link
Contributor

@esbenam esbenam commented May 11, 2020

In 3.1.1 react-fast-compare added support for preact's internal data
structure when handling recursive objects so it now ignores those
correctly. This means the maximum call stack size exceeded issue
doesn't happen any longer.

@esbenam
Copy link
Contributor Author

esbenam commented May 11, 2020

It seems to be complaining about yarn.lock vs package-lock.json. Do I have to use yarn to update the dependency?

@cwelch5
Copy link
Contributor

cwelch5 commented May 11, 2020

@esbenam I think so for now until we settle on a standard.

In 3.1.1 react-fast-compare added support for preact's internal data
structure when handling recursive objects so it now ignores those
correctly. This means the maximum call stack size exceeded issue
doesn't happen any longer.
@esbenam esbenam force-pushed the update-react-fast-compare-for-preact-compatibility branch from 48cde49 to 12d05ba Compare May 12, 2020 06:23
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #559 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #559   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files           3        3           
  Lines         292      292           
=======================================
  Hits          283      283           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9e0245...12d05ba. Read the comment docs.

@esbenam
Copy link
Contributor Author

esbenam commented May 12, 2020

@cwelch5 it seems that did the trick. I have signed the CLA, but the CLAAssistant doesn't seem to pick up on it. Do I have to do anything else?

@esbenam
Copy link
Contributor Author

esbenam commented May 13, 2020

I can see you already have dependabot creating the same PR. Should I just close this on?

@cwelch5
Copy link
Contributor

cwelch5 commented May 13, 2020

Thanks @esbenam , but I'll look at yours over the bots 😂 - you deserve the credit. Let me give it a quick run through on my machine because it is a major upgrade of a core dependency.

@zsolt-dev
Copy link

Thank you @esbenam.

@cwelch5 Any idea when this is going to get into release? Many broken preact apps are waiting for this...

@cwelch5
Copy link
Contributor

cwelch5 commented Jun 18, 2020

Released with 6.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants