Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure "data-react-helmet" always renders its value as "true" #658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure "data-react-helmet" always renders its value as "true" #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/HelmetUtils.js
View file
Open in desktop
Expand Up @@ -553,7 +553,7 @@ const generateTitleAsReactComponent = (type, title, attributes) => {
// assigning into an array to define toString function on it
const initProps = {
key: title,
[HELMET_ATTRIBUTE]: true
[HELMET_ATTRIBUTE]: "true"
};
const props = convertElementAttributestoReactProps(attributes, initProps);

Expand All @@ -564,7 +564,7 @@ const generateTagsAsReactComponent = (type, tags) =>
tags.map((tag, i) => {
const mappedTag = {
key: i,
[HELMET_ATTRIBUTE]: true
[HELMET_ATTRIBUTE]: "true"
};

Object.keys(tag).forEach(attribute => {
Expand Down