Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primaryAttributeKey check for string #662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asifrahman001
Copy link

@asifrahman001 asifrahman001 commented Dec 23, 2021

If tag[primaryAttributeKey] is not string, it should return false. Since, In many cases we have tag[primaryAttributeKey] as object.

We get this error if the attr is an object
TypeError: tag[primaryAttributeKey].toLowerCase is not a function at /node_modules/react-helmet/lib/HelmetUtils.js:124:100 at Array.filter (<anonymous>) at /node_modules/react-helmet/lib/HelmetUtils.js:100:22 at Array.reduce (<anonymous>) at getTagsFromPropsList (/node_modules/react-helmet/lib/HelmetUtils.js:97:18) at reducePropsToState (/node_modules/react-helmet/lib/HelmetUtils.js:181:19)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Asif Rahman seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants