Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump c++ standard to 14 #1019

Closed
wants to merge 1 commit into from
Closed

bump c++ standard to 14 #1019

wants to merge 1 commit into from

Conversation

kloczek
Copy link

@kloczek kloczek commented Oct 23, 2023

Fixes #1018

Fixes #1018

Signed-off-by: Tomasz Kłoczko <kloczek@github.com>
@ffilz
Copy link
Member

ffilz commented Oct 23, 2023

Please submit via gerrithub - see src/CONTRIBUTING_HOWTO.txt

@kloczek
Copy link
Author

kloczek commented Oct 23, 2023

Guthub provides REALLY ALL what is necessary to do code review.
Second: this is single line patch with obvious fix.
If you have some requirements about code review this is not my problem.
I've already spend enough time on this issue.
Feel free to close this PR.

Please keep simple things simple.

@xiaods
Copy link

xiaods commented May 19, 2024

@kloczek please submit this pr to gerrit, it good for review. thanks a lot

@kloczek
Copy link
Author

kloczek commented May 19, 2024

@kloczek please submit this pr to gerrit, it good for review. thanks a lot

gerrit? 🤔

@xiaods
Copy link

xiaods commented May 20, 2024

@kloczek please submit this pr to gerrit, it good for review. thanks a lot

gerrit? 🤔

Please submit a patch via Gerrithub (see src/CONTRIBUTING_HOWTO.txt).

@dang
Copy link
Contributor

dang commented May 20, 2024

This is already submitted here:

https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1194724

@ffilz
Copy link
Member

ffilz commented May 20, 2024

@kloczek please submit this pr to gerrit, it good for review. thanks a lot

gerrit? 🤔

Please submit a patch via Gerrithub (see src/CONTRIBUTING_HOWTO.txt).

Yes, we use Gerrithub for code submissions as documented as noted.

@ffilz
Copy link
Member

ffilz commented May 20, 2024

Closing as a duplicate now.

@ffilz ffilz closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants