fix(modal): remove key/mouse handlers only when modal is destroyed #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benouat could you PTAL? |
benouat
approved these changes
Jan 7, 2020
At the moment key/mouse handlers are removed when modal triggers dismiss event. The problem is that modal closure could be cancelled with `beforeDismiss` and modal will stay opened, but handlers will be removed. This commit introduces `closed$` event triggered inside `onDestroy` to clean up handlers. Fixes ng-bootstrap#3515
maxokorokov
force-pushed
the
modal/fix/stacked-handlers-lost
branch
from
85aeb51
to
1c02d2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #3532 +/- ##
==========================================
+ Coverage 91.41% 91.42% +<.01%
==========================================
Files 96 96
Lines 2807 2809 +2
Branches 518 518
==========================================
+ Hits 2566 2568 +2
Misses 183 183
Partials 58 58
Continue to review full report at Codecov.
|
maxokorokov
added a commit
that referenced
this pull request
Jan 7, 2020
…3532) At the moment key/mouse handlers are removed when modal triggers dismiss event. The problem is that modal closure could be cancelled with `beforeDismiss` and modal will stay opened, but handlers will be removed. This commit introduces `closed$` event triggered inside `onDestroy` to clean up handlers. Fixes #3515
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment key/mouse handlers are removed when modal triggers dismiss event. The problem is that modal closure could be cancelled with
beforeDismissand modal will stay opened, but handlers will be removed.This commit introduces
closed$event triggered insideonDestroyto clean up handlers.Fixes #3515