Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): remove key/mouse handlers only when modal is destroyed #3532

Merged
merged 1 commit into from Jan 7, 2020
Merged

fix(modal): remove key/mouse handlers only when modal is destroyed #3532

merged 1 commit into from Jan 7, 2020

Commits on Jan 7, 2020

  1. fix(modal): remove key/mouse handlers only when modal is destroyed 

    At the moment key/mouse handlers are removed when modal triggers dismiss event. The problem is that modal closure could be cancelled with `beforeDismiss` and modal will stay opened, but handlers will be removed.

This commit introduces `closed$` event triggered inside `onDestroy` to clean up handlers.

Fixes ng-bootstrap#3515
    @maxokorokov
    maxokorokov committed Jan 7, 2020
    Copy the full SHA
    1c02d2c View commit details
    Browse the repository at this point in the history