feat(datepicker): keep day/month when adding/removing month/year in ngb-calendar #1277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gb-calendar BREAKING CHANGES: ngb-calendar getNext/getPrev specifications changed `calendar.getNext()`/`calendar.getPrev()` with the period parameter set as `'m'`/`'y'` no longer automatically returns the first day of the month / the first day of the year. The day in the month and the month in the year of the input date are now kept as much as possible. In case the destination month is is not long enough to contain a day with the same number, the last day of the month is used. For example: `calendar.getNext(new NgbDate(2016, 7, 22), 'm'))` previously returned: `new NgbDate(2016, 8, 1))` and now it returns: `new NgbDate(2016, 8, 22))` `calendar.getNext(new NgbDate(2016, 7, 22), 'y'))` previously returned: `new NgbDate(2017, 1, 1))` and now it returns: `new NgbDate(2017, 7, 22))` `calendar.getNext(new NgbDate(2016, 1, 30), 'm'))` previously returned: `new NgbDate(2016, 2, 1))` and now it returns: `new NgbDate(2016, 2, 29))` (because 2016-02-30 is not a valid date)
maxokorokov
approved these changes
Apr 13, 2017
maxokorokov
requested changes
Apr 27, 2017
|
@maxokorokov @divdavem what is the status of this one? Is it still relevant? |
|
This commit was cherrypicked and merged in #3355 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a change I am suggesting: I think
calendar.getNext()/calendar.getPrev()with the period parameter set as'm'/'y'should not automatically return the first day of the month / the first day of the year.I think the day in the month and the month in the year of the input date should be kept as much as possible in the returned value. In case the destination month is is not long enough to contain a day with the same number, the last day of the month should be used.
For example:
calendar.getNext(new NgbDate(2016, 7, 22), 'm'))previously returned:
new NgbDate(2016, 8, 1))with this PR, it returns:
new NgbDate(2016, 8, 22))calendar.getNext(new NgbDate(2016, 7, 22), 'y'))previously returned:
new NgbDate(2017, 1, 1))with this PR, it returns:
new NgbDate(2017, 7, 22))calendar.getNext(new NgbDate(2016, 1, 30), 'm'))previously returned:
new NgbDate(2016, 2, 1))with this PR, it returns:
new NgbDate(2016, 2, 29))(because 2016-02-30 is not a valid date)
Especially, I think this feature is useful for #1273 when pressing page up/page down to change the month or shift+page up/shift+page down to change the year.
@maxokorokov: What do you think?