feat(datepicker): add accessibility (work in progress) #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following shortcuts are available: Arrow left/right: previous/next day Arrow up/down: previous/next week Page up/down: previous/next month Shift+page up/down: previous/next year Home/end: beginning/end of the current view Shift+home/end: min/max selectable date
divdavem
force-pushed
the
datepickerAccessibility
branch
from
f382c2d
to
9136519
Compare
BREAKING CHANGES: NgbDatepickerI18n has a new getWeekdayFullName method
divdavem
force-pushed
the
datepickerAccessibility
branch
from
9136519
to
0fa5e47
Compare
|
@divdavem what is the status of this one, especially given #2165? |
|
Will close this one as @ExFlo used it as a starting point. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is built on top of #1273
It adds ARIA attributes to make the
ngb-datepickerusable with screen readers.I checked with the latest version of NVDA on the latest version of Chrome and it works.
This is a work in progress
Here is the remaining work to do: