feat(modal): add component instance type #1771
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: you now need to pass a component type to the modal open function. Before: ``` modalService.open(ModalComponent); ``` After: ``` modalService.open<ModalComponent>(ModalComponent); ```
|
Thnx for the PR but we will rather go with the solution outlined in #2479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE:
you now need to pass a component type to the modal open function.
Before:
After:
Before submitting a pull request, please make sure you have at least performed the following:
It may be better to wait for TS 2.3 as a minimum where generic defaults are possible, so it would be a better breaking change for users as it would only require them to upgrade their TS version.