Merge fix(tabset): remove aria-expanded and use aria-selected instead…

[constantincechina]

… (#3292) from 5.1.0 to 4.2.x

Before submitting a pull request, please make sure you have at least performed the following:

• read and followed the CONTRIBUTING.md guide.
• built and tested the changes locally.
• added/updated any applicable tests.
• [] added/updated any applicable API documentation.
• added/updated any applicable demos.

This is a fix ported from version 5.1.0

[codecov-io]

Codecov Report

Merging #3323 into 4_2_x will increase coverage by 1.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            4_2_x    #3323      +/-   ##
==========================================
+ Coverage   92.04%   93.05%   +1.01%     
==========================================
  Files          91       91              
  Lines        3054     3053       -1     
  Branches      505      505              
==========================================
+ Hits         2811     2841      +30     
+ Misses        179      174       -5     
+ Partials       64       38      -26

Flag	Coverage Δ
#e2e	66.83% <ø> (+3.83%)	⬆️
#unit	89.47% <ø> (ø)	⬆️

Impacted Files	Coverage Δ
src/tabset/tabset.ts	100% <ø> (ø)	⬆️
src/util/accessibility/live.ts	92.59% <0%> (-3.71%)	⬇️
src/typeahead/typeahead.ts	96.68% <0%> (-0.67%)	⬇️
src/dropdown/dropdown.ts	94.01% <0%> (-0.6%)	⬇️
src/index.ts	100% <0%> (ø)	⬆️
src/util/autoclose.ts	84% <0%> (ø)	⬆️
src/datepicker/datepicker-input.ts	97.98% <0%> (+0.67%)	⬆️
src/modal/modal-stack.ts	96.63% <0%> (+0.84%)	⬆️
src/rating/rating.ts	98.64% <0%> (+1.35%)	⬆️
src/datepicker/datepicker-service.ts	99.23% <0%> (+1.53%)	⬆️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a17683...a2de4a2. Read the comment docs.

[constantincechina]

@fbasso Can you please take a look at the current PR? Thanks

[constantincechina]

@benouat Can you please take a look at the current PR? Thanks

[constantincechina]

@maxokorokov Can you please take a look at the current PR?
This issue has been fixed in latest version(5.x) - that make use of Angular > 8.x. However for the projects that are using version 7 of Angular - this fix is not available.

Is the development and support no longer available for the version 4 - and if so, where info is available/published?
Thanks

[benouat]

Hey @constantincechina !
Sorry for the delay... Summer vacation side effects!

Your PR seems to have a bit changes that it should.
Could you please remove the things related to code-highlight.service.ts and also the version change from package.json (which resulted in also updating the yarn.lock)

If you feel more confortable, we could do the corresponding cherry-pick ourselves directly on the 4.2.x branch without going via PR and publish a new version. Just tell me.

[constantincechina]

Good evening @benouat and thanks for the reply! vacation in August - looks like you are working for Government agency :D.

I'll check the things you mentioned - however - I recall that simply trying just to merge the fix, did not work and was failing the Travis CI.
The changes added to package.json were required to fix the protractor version issue for the Chrome headless browser that was not able to identify the correct version.

In regards to the code-highlight.service.ts that was due to the upgrade version for @angular-devkit/build-angular. I'll try to revert these and post the update here.

[maxokorokov]

@constantincechina thanks for the PR, but it was much easier for me to cherry-pick the commit and do a release from there. It's a part or 4.2.2 now.