New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

componentInstance is undefined if _contentRef is null #3367

Merged

maxokorokov merged 1 commit into ng-bootstrap:master from loicgasser:modal_ref

Oct 3, 2019

Contributor

loicgasser commented Sep 16, 2019

Before submitting a pull request, please make sure you have at least performed the following:

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated any applicable tests.
added/updated any applicable API documentation.
added/updated any applicable demos.

fixes #3366


          componentInstance is undefined if _contentRef is null

4658d0b

maxokorokov added component: modal needs: review labels

maxokorokov added this to the 5.1.2 milestone

maxokorokov approved these changes

View reviewed changes

Member

maxokorokov left a comment

LGTM, thanks!

maxokorokov removed the needs: review label

maxokorokov merged commit c60a012 into ng-bootstrap:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment