Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): add missing fields to NgbModalConfig #3406

Merged
merged 3 commits into from Oct 18, 2019
Merged

fix(modal): add missing fields to NgbModalConfig #3406

merged 3 commits into from Oct 18, 2019

Commits on Oct 8, 2019

  1. fix(modal): add missing fields to NgbModalConfig 

    This fixes compile error when a user tries to set any of this fields in a
`NgbModalConfig` instance.
    @gentoo90
    gentoo90 committed Oct 8, 2019
    Copy the full SHA
    bee4204 View commit details
    Browse the repository at this point in the history

  2. test(modal): check default value of NgbModalConfig

    @gentoo90
    gentoo90 committed Oct 8, 2019
    Copy the full SHA
    f4bd47b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. fix(modal): implement Required<NgbModalOptions> in NgbModalConfig

    @gentoo90
    gentoo90 committed Oct 17, 2019
    Copy the full SHA
    d0c1baa View commit details
    Browse the repository at this point in the history