Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ie): local configuration for InternetExplorer #3410

Merged

Conversation

peterblazejewicz
Copy link
Contributor

The project comes with confgiguration for local IE build supporting ES5
and for SouceLabs remote configuration for IE browsers, but it has no
relevant entry to allow tests on local setup. This are minimal changes
to allow local tests with IE on Windows box.
Example syntax:

yarn test --browsers IENoExtensions --configuration ie

There is no configuration for size of the launched IE instance, so in
order to have tests depending on the viewport size - like overlays
positioning on top/left/right/bottom, the IE instance has been
configured to run in the kiosk mode ('-k').

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.

Aftermant of the discussion here:
#3406 (comment)

 yarn test --browsers IENoExtensions --configuration ie
yarn run v1.19.1
$ yarn check-format && yarn ngb:lint && yarn ngb:test --browsers IENoExtensions --configuration ie
$ ts-node --project misc/tsconfig.json misc/check-format.ts
$ ng lint ng-bootstrap
Linting "ng-bootstrap"...
All files pass linting.
$ ng test ng-bootstrap --code-coverage --source-map true --progress false --watch false --browsers IENoExtensions --configuration ie
12 10 2019 22:53:25.150:INFO [karma-server]: Karma v4.1.0 server started at http://0.0.0.0:9876/
12 10 2019 22:53:25.165:INFO [launcher]: Launching browsers IENoExtensions with concurrency unlimited
12 10 2019 22:53:25.250:INFO [launcher]: Starting browser IE
12 10 2019 22:53:46.341:INFO [IE 11.0.0 (Windows 10.0.0)]: Connected on socket NBxsVB1-gl2i6UQbAAAA with id 29134295
IE 11.0.0 (Windows 10.0.0): Executed 1268 of 1268 SUCCESS (2 mins 11.087 secs / 2 mins 3.148 secs)
TOTAL: 1268 SUCCESS
TOTAL: 1268 SUCCESS
Done in 194.15s

The project comes with confgiguration for local IE build supporting ES5
and for SouceLabs remote configuration for IE browsers, but it has no
relevant entry to allow tests on local setup. This are minimal changes
to allow local tests with IE on Windows box.
Example syntax:
```bash
yarn test --browsers IENoExtensions --configuration ie
```
There is no configuration for size of the launched IE instance, so in
order to have tests depending on the viewport size - like overlays
positioning on top/left/right/bottom, the IE instance has been
configured to run in the kiosk mode ('-k').
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@maxokorokov maxokorokov merged commit ad2800d into ng-bootstrap:master Oct 17, 2019
@peterblazejewicz peterblazejewicz deleted the tests/local-profile-ie branch October 18, 2019 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants