Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): use readonly arrays for inputs (#2773) #3424

Merged
merged 1 commit into from Dec 6, 2019
Merged

feat(datepicker): use readonly arrays for inputs (#2773) #3424

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datepicker/hebrew/ngb-calendar-hebrew.ts
View file
Open in desktop
Expand Up @@ -64,7 +64,7 @@ export class NgbCalendarHebrew extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
const date = week[week.length - 1];
return Math.ceil(getDayNumberInHebrewYear(date) / 7);
}
Expand Down
2 changes: 1 addition & 1 deletion src/datepicker/hijri/ngb-calendar-hijri.ts
View file
Open in desktop
Expand Up @@ -57,7 +57,7 @@ export abstract class NgbCalendarHijri extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
// in JS Date Sun=0, in ISO 8601 Sun=7
if (firstDayOfWeek === 7) {
firstDayOfWeek = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/datepicker/jalali/ngb-calendar-persian.ts
View file
Open in desktop
Expand Up @@ -41,7 +41,7 @@ export class NgbCalendarPersian extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
// in JS Date Sun=0, in ISO 8601 Sun=7
if (firstDayOfWeek === 7) {
firstDayOfWeek = 0;
Expand Down
4 changes: 2 additions & 2 deletions src/datepicker/ngb-calendar.ts
View file
Open in desktop
Expand Up @@ -75,7 +75,7 @@ export abstract class NgbCalendar {
/**
* Returns the week number for a given week.
*/
abstract getWeekNumber(week: NgbDate[], firstDayOfWeek: number): number;
abstract getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number): number;

/**
* Returns the today's date.
Expand Down Expand Up @@ -139,7 +139,7 @@ export class NgbCalendarGregorian extends NgbCalendar {
return day === 0 ? 7 : day;
}

getWeekNumber(week: NgbDate[], firstDayOfWeek: number) {
getWeekNumber(week: readonly NgbDate[], firstDayOfWeek: number) {
// in JS Date Sun=0, in ISO 8601 Sun=7
if (firstDayOfWeek === 7) {
firstDayOfWeek = 0;
Expand Down