Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pagination): simplify the way disabled links are handled #3474

Merged

Conversation

maxokorokov
Copy link
Member

Small refactoring after #3468 and #3471:

  • ellipsis should always be disabled
  • use prevDisabled() and nextDisabled() where possible

@codecov-io
Copy link

Codecov Report

Merging #3474 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3474   +/-   ##
=======================================
  Coverage   91.14%   91.14%           
=======================================
  Files          96       96           
  Lines        2800     2800           
  Branches      516      516           
=======================================
  Hits         2552     2552           
  Misses        190      190           
  Partials       58       58
Flag Coverage Δ
#e2e 56.21% <ø> (ø) ⬆️
#unit 87.99% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/pagination/pagination.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0a2bda...d5c6ede. Read the comment docs.

@benouat benouat merged commit 0f60871 into ng-bootstrap:master Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants