Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): fix scrollbar compensation in some scaling situations #3498

Merged
merged 2 commits into from Dec 5, 2019
Merged

fix(modal): fix scrollbar compensation in some scaling situations #3498

merged 2 commits into from Dec 5, 2019

Commits on Dec 2, 2019

  1. fix(modal): fix scrollbar compensation in some scaling situations 

    Now the actual width of the scrollbar is used to detect if it is present or not, instead of using the wrong hypothesis that if body's rect's width is smaller than viewport's width then there is a scrollbar. Now the difference in width is compared to the width of the scrollbar.

Closes ng-bootstrap#3448
    @ymeine
    ymeine committed Dec 2, 2019
    Copy the full SHA
    80c8504 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. fix(modal): fix scrollbar compensation in some scaling situations 

    Adding uncertainty, because the scaling can make the gap just slightly smaller than a scrollbar size.

Closes ng-bootstrap#3448
    @ymeine
    ymeine committed Dec 3, 2019
    Copy the full SHA
    c6493c3 View commit details
    Browse the repository at this point in the history