Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11, Edge: This change ensures the arrow icon on selects doesn't disappears on focus #3527

Merged

Conversation

qf-jonathan
Copy link
Contributor

This change ensures the arrow icon on selects doesn't disappear when it gains focus, issue #3526

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@codecov-io
Copy link

Codecov Report

Merging #3527 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3527   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files          96       96           
  Lines        2800     2800           
  Branches      517      517           
=======================================
  Hits         2559     2559           
  Misses        183      183           
  Partials       58       58
Flag Coverage Δ
#e2e 56.46% <ø> (ø) ⬆️
#unit 88.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 117d239...8be4ce7. Read the comment docs.

Copy link
Contributor

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@qf-jonathan Thanks for contribution!

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maxokorokov maxokorokov merged commit d457ef7 into ng-bootstrap:master Jan 2, 2020
@qf-jonathan qf-jonathan deleted the bug-ie11-edge-arrow-disappear branch January 2, 2020 16:06
@maxokorokov maxokorokov modified the milestones: 5.2.0, 5.1.5 Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants