Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): add a custom class to set the header padding #4611

Merged

Conversation

bastienmoulia
Copy link
Contributor

fix #4608

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b5768b) 89.92% compared to head (3d30b4b) 89.92%.
Report is 19 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4611      +/-   ##
==========================================
- Coverage   89.92%   89.92%   -0.01%     
==========================================
  Files         118      118              
  Lines        3742     3741       -1     
  Branches      734      734              
==========================================
- Hits         3365     3364       -1     
  Misses        341      341              
  Partials       36       36              
Flag Coverage Δ
e2e ∅ <ø> (∅)
unit 89.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/dropdown/dropdown.module.ts 100.00% <ø> (ø)
src/dropdown/dropdown.ts 59.34% <ø> (-0.23%) ⬇️
src/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!
It's been there for quite a while actually!

@maxokorokov maxokorokov merged commit fc6100f into ng-bootstrap:master Nov 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Padding of .ngb-dp-header for datepicker different in documentation
3 participants