Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthpicker #4613

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

Conversation

bastienmoulia
Copy link
Contributor

WIP for ##1811

@maxokorokov
Copy link
Member

Hey, @bastienmoulia, this looks... big, haha.
I really do appreciate the effort to fix this though.

I don't think we should duplicate the datepikcer's code to make a monthpicker. It's already old and with quite a bit of technical debt in it. And we have new primitives to make it simpler as well (ex. signals). I don't think we should introduce new things like NgbMonth, I18n, Calendar (especially Calendar!).

I was playing with this on my side as well, I don't think it will make it for the next major, but I should share it soon as well.

On my side I was focusing on:

  • making the datepicker "backend" signal-based
  • making the layout responsive
  • introduce @Input() zoom: 'days' | 'months | 'years' to change the view
  • introduce @Input() mode: 'days' | 'months' to decide what should be selected

I'd also like to see how far what we have is from Temporal proposal, but this is probably for another day.

@bastienmoulia
Copy link
Contributor Author

It's a bit big I now. I made a monthpicker for a personal project so I would like to share how it can be done. But I'm agree with you, it's not very optimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants