-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ngbp to use latest available tools and packages #232
Conversation
…et" instead of "configure" in karma test template
…ody (best practice)
@johannestroeger updated to require bower 1.2.8, I assume that's what you were getting at here? |
ok. now add a semicolon please 🎯 |
doh, updated. :) |
👍 it passed |
Awesome, works great! However Bootstrap is still 2.x version. Any plans to update also to bootstrap 3? |
I was hoping that the pull request would be merged in before I did that as well. I have updated bootstrap to 3.x on my local system, but it makes the PR all the harder to accept when there's so much going on. Having said that, it's been over two weeks with no response from the project.. so it may be worth just going ahead and updating that as well |
Looking forward to it. Hopefully someone who is interested to keep this up-to-date will start fork from this, where necessary pull requests could be merged. |
I did upgrade by myself as well, for Angular too. I cannot handle the fork Adam
|
maybe this one https://github.com/kvindasAB/angular-enterprise-kickstart |
@svycka thanks, I think that it's time to move on, sadly the project seems to be dead. last commit was 4 months ago. |
There was way too much going on in this PR to merge all at once. It also started clashing with other PRs because of the broad scope of changes. :-) However, all of these changes have been merged incrementally across several different commits in the v0.3.2-wip branch which will become the default branch once I finish merging PRs. Thanks!!! FYI, @diego-vieira - It's been very slow-going as I've been super busy with work and a lot of people have made the same observation about how long ago the last commit was. However, it's not true. The last commit on the default branch was 4 months ago, but that's because it's a release branch - there will never be any commits there. If you look at the other branches, there have been many commits over the last few months, mostly for the rewrite. But in either event, I agree that PRs sat around for far too long. |
This branch is labeled "update-angular", because the initial intent was to update to angular 1.3, however, it ended up being a general "update ngbp" instead. As a result, I propose the included change to bump the version to 0.3.2.