Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ngbp to use latest available tools and packages #232

Closed
wants to merge 6 commits into from

Conversation

mbroadst
Copy link

This branch is labeled "update-angular", because the initial intent was to update to angular 1.3, however, it ended up being a general "update ngbp" instead. As a result, I propose the included change to bump the version to 0.3.2.

@0x6a68
Copy link

0x6a68 commented Mar 11, 2014

bower/bower#1102

@mbroadst
Copy link
Author

@johannestroeger updated to require bower 1.2.8, I assume that's what you were getting at here?

@0x6a68
Copy link

0x6a68 commented Mar 11, 2014

ok. now add a semicolon please 🎯

@mbroadst
Copy link
Author

doh, updated. :)

@0x6a68
Copy link

0x6a68 commented Mar 11, 2014

👍 it passed

@elhigu
Copy link

elhigu commented Mar 28, 2014

Awesome, works great! However Bootstrap is still 2.x version. Any plans to update also to bootstrap 3?

@mbroadst
Copy link
Author

I was hoping that the pull request would be merged in before I did that as well. I have updated bootstrap to 3.x on my local system, but it makes the PR all the harder to accept when there's so much going on. Having said that, it's been over two weeks with no response from the project.. so it may be worth just going ahead and updating that as well

@elhigu
Copy link

elhigu commented Mar 28, 2014

Looking forward to it. Hopefully someone who is interested to keep this up-to-date will start fork from this, where necessary pull requests could be merged.

@108adams
Copy link

I did upgrade by myself as well, for Angular too. I cannot handle the fork
by myself, but can help if there is a fork.

Adam
28-03-2014 14:16, "Mikael Lepistö" notifications@github.com napisał(a):

Looking forward to it. Hopefully someone who is interested to keep this
up-to-date will start fork from this, where necessary pull requests could
be merged.


Reply to this email directly or view it on GitHubhttps://github.com//pull/232#issuecomment-38923152
.

@svycka
Copy link

svycka commented Mar 31, 2014

@dv336699
Copy link

@svycka thanks, I think that it's time to move on, sadly the project seems to be dead. last commit was 4 months ago.

@joshdmiller
Copy link
Member

There was way too much going on in this PR to merge all at once. It also started clashing with other PRs because of the broad scope of changes. :-)

However, all of these changes have been merged incrementally across several different commits in the v0.3.2-wip branch which will become the default branch once I finish merging PRs. Thanks!!!

FYI, @diego-vieira - It's been very slow-going as I've been super busy with work and a lot of people have made the same observation about how long ago the last commit was. However, it's not true. The last commit on the default branch was 4 months ago, but that's because it's a release branch - there will never be any commits there. If you look at the other branches, there have been many commits over the last few months, mostly for the rewrite. But in either event, I agree that PRs sat around for far too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants