Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove replace no longer needed #1900

Merged
merged 2 commits into from Apr 29, 2024
Merged

Remove replace no longer needed #1900

merged 2 commits into from Apr 29, 2024

Conversation

lucacome
Copy link
Member

@lucacome lucacome commented Apr 29, 2024 •
edited

Proposed changes

After onsi/ginkgo#1396 and in turn #1892 the replace is no longer needed

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@lucacome lucacome requested a review from a team as a code owner April 29, 2024 17:25
@github-actions github-actions bot added dependencies Pull requests that update a dependency file chore Pull requests for routine tasks labels Apr 29, 2024
sjberman
sjberman approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@sjberman sjberman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@lucacome lucacome merged commit e082924 into nginxinc:main Apr 29, 2024
38 checks passed
@lucacome lucacome deleted the chore/remove-replace branch April 29, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjberman sjberman sjberman approved these changes

@kate-osborn kate-osborn kate-osborn approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
NGINX Gateway Fabric
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucacome @sjberman @kate-osborn