Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dom-selectors): byRole typings #591

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

HafizAhmedMoon
Copy link
Contributor

@HafizAhmedMoon HafizAhmedMoon commented Nov 2, 2022

Add proper typings to byRole to get role autocomplete

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #589

What is the new behavior?

Updated the byRole typings to provide role autocomplete.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Add proper typings to `byRole` to get role autocomplete
@stackblitz
Copy link

stackblitz bot commented Nov 2, 2022

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@NetanelBasal NetanelBasal merged commit e537f64 into ngneat:master Nov 2, 2022
@HafizAhmedMoon HafizAhmedMoon deleted the fix-by-role-typings branch November 2, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants