Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spectator): Support input signals #638

Merged
merged 8 commits into from Feb 17, 2024

Conversation

kfrancois
Copy link
Contributor

@kfrancois kfrancois commented Jan 31, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: https://github.com/ngneat/spectator/blob/master/CONTRIBUTING.md#commit
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Types have been cleaned up as SpectatorDirectiveFactory, SpectatorHostFactory and their related types need some cleanup as the component's generic param is not used everywhere

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #637

What is the new behavior?

Does this PR introduce a breaking change?

[X] Yes
[ ] No

setProps and props were removed from createHostFactory and createDirectiveFactory. Props should be set through setHostProps and hostProps instead.

Other information

Copy link

stackblitz bot commented Jan 31, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@kfrancois
Copy link
Contributor Author

This is not ready to merge, see #637

BREAKING CHANGE: remove 'props' and 'setProps' from host/directive
factories
@kfrancois kfrancois changed the title feat(spectator): wip implementation for input signals support feat(spectator): Support input signals Feb 14, 2024
@NetanelBasal
Copy link
Member

LGTM, let's finish it

Fixed type names of InferSignalInputs and InputSignalInput (which was a
typo) to be aligned with Angular's InputSignal type, rather than
SignalInput
@kfrancois
Copy link
Contributor Author

@NetanelBasal I added some cleanup commits, are there any specific changes to docs or other changes you'd like me to make do to ensure this is in a good state to merge? I'd be glad to take them up 😄

@NetanelBasal
Copy link
Member

We need to update the README to reflect this change:

setProps and props were removed from createHostFactory and createDirectiveFactory. Props should be set through setHostProps and hostProps instead.

Added disclaimers for createHostFactory, createDirectiveFactory, and
createPipeFactory as they don't support props/setProps anymore.
@kfrancois
Copy link
Contributor Author

kfrancois commented Feb 16, 2024

Great suggestion, thanks! I added some changes to the README but if you want to make any further changes, go ahead 😄 you're much more familiar with the writing style of docs in this repo, so please make any changes you want.

(edit: I added you as collaborator to the fork so you can add any commits you want)

@NetanelBasal NetanelBasal merged commit 3f63c68 into ngneat:master Feb 17, 2024
3 checks passed
@kfrancois kfrancois deleted the support-input-signals branch February 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants