fix: 🐛 component re-render when updating fields in lifecycle hook

[kfrancois]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngneat/spectator/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

See #643

When Spectator is used to set inputs on a component, the following will happen:

1. ChangeDetectorRef.detectChanges() is called
2. fixture.detectChanges is called

Issue Number: #643

What is the new behavior?

I simply swapped these 2 calls:

1. fixture.detectChanges will run a change detection cycle on the test fixture. This is when ngOnChanges will run
2. ChangeDetectorRef.detectChanges() will check the component view. This is where the change detection check will detect the updated field from ngOnChanges and re-render the component.

I wish I could give a better explanation to why this happens, but this is my interpretation of the bug/fix

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

[stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[kfrancois]

Seeing 1 test fail which did succeed locally - will investigate when I have time after work.

[kfrancois]

@NetanelBasal could you check this failing CI run? The failing test succeeds locally, I wonder if the flakiness is due to CI.

One weird thing I'm seeing is that the CI job runs 290 tests, while locally I only have 280 tests 🤔

[NetanelBasal]

Maybe there is a skip some where?

[kfrancois]

Got it, I simply didn't rebase on latest master - I messed up in this commit 3f63c68 by focusing a test in Jasmine (which means all other tests were skipped), and in the meantime a test got broken. Should be g2g now!

[Blafasel3]

Suggested change

	export class NgOnChangesInputComponent {
	export class OnPushComponent {

I think thats more to the point.

[NetanelBasal]

Correct, but let's not wait for this fix