Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spectator): set input accepts alias names #652

Merged
merged 2 commits into from Mar 21, 2024
Merged

fix(spectator): set input accepts alias names #652

merged 2 commits into from Mar 21, 2024

Conversation

profanis
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@stackblitz StackBlitz
Copy link

stackblitz bot commented Mar 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@profanis profanis mentioned this pull request Mar 21, 2024
Closed
NetanelBasal
NetanelBasal reviewed Mar 21, 2024
View reviewed changes
projects/spectator/jest/test/set-input-alias-names.spec.ts Outdated
standalone: true,
})
class DummyComponent {
@Input('userName') name!: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add the signal input alias variations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure! I added the relevant unit tests

@NetanelBasal NetanelBasal merged commit 13c8bf1 into ngneat:master Mar 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NetanelBasal NetanelBasal Awaiting requested review from NetanelBasal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@profanis @NetanelBasal