chore: update eslint and nx deps #3371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io canceled.
|
timdeschryver
commented
Apr 8, 2022
| @@ -113,7 +121,6 @@ | |||
| "undefined" | |||
| ], | |||
| "id-match": "error", | |||
| "import/no-deprecated": "warn", | |||
There was a problem hiding this comment.
Removed because this was taking too long 😅
timdeschryver
commented
Apr 8, 2022
| @@ -636,7 +636,7 @@ | |||
| "outputs": ["coverage/modules/schematics"] | |||
| }, | |||
| "build-package": { | |||
| "builder": "@nrwl/node:package", | |||
There was a problem hiding this comment.
Changed in nrwl/nx#9086
timdeschryver
force-pushed
the
update-eslint-deps
branch
from
87d7f0c
to
2f0a490
Compare
timdeschryver
commented
Apr 8, 2022
| @@ -235,7 +235,7 @@ jobs: | |||
| - write_master_hash | |||
| - run: | |||
| name: Run Affected E2E Tests | |||
| command: yarn nx affected --target=e2e --base=$(cat ~/project/master.txt) --head=$CIRCLE_SHA1 --headless --parallel | |||
| command: yarn nx affected --target=e2e --base=$(cat ~/project/master.txt) --head=$CIRCLE_SHA1 --parallel --exclude=docs-app | |||
There was a problem hiding this comment.
I'm not sure why docs-app is getting picked up as a project that has the e2e target, that's why I just excluded it here 😅
brandonroberts
approved these changes
Apr 9, 2022
markostanimirovic
approved these changes
Apr 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Closes #
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Before I started the migratation of the ESLint plugin, I wanted this repo to be on the latest ESLint version (8). By doing that, I also had to update the NX dependencies.
I also had to make some changes to make the
ng linthappy.