Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nebular): Added nebular support #3360

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vijhhh2
Copy link

@vijhhh2 vijhhh2 commented Jun 27, 2022

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature.

What is the current behavior? (You can also link to an open issue here)
N/A

What is the new behavior (if this is a feature change)?
This PR aims to implement support for the Nebular UI for Angular.

Please check if the PR fulfills these requirements

Please provide a screenshot of this feature before and after your code changes, if applicable.

Other information:

@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for formly-dev ready!

Name Link
🔨 Latest commit b48f11f
🔍 Latest deploy log https://app.netlify.com/sites/formly-dev/deploys/62b95f992437a80008d4e6f4
😎 Deploy Preview https://deploy-preview-3360--formly-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MaxKless
Copy link
Collaborator

MaxKless commented Jul 6, 2022

Super cool that you built an entire new theme for formly!
I'm wondering, thinking about the long-term health and maintainability of formly, is it smart to add more stuff to the main formly repo?
I know that @aitboudad has already said he'd do it but I feel like he's very busy these days and adding more code might be a burden that distracts from core formly maintenance and development.

Especially since there is already a great package that can simply be plugged into any project.

@vijhhh2
Copy link
Author

vijhhh2 commented Jul 7, 2022

I agree with @MaxKless on this

@MaxKless
Copy link
Collaborator

So, should we close this, @aitboudad @vijhhh2 ?

@aitboudad
Copy link
Member

I tend to agree with some points here, I will think about it after finishing with V6 release 🙏!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants