Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies to latest versions #332

Closed
wants to merge 9 commits into from
Closed

Update dependencies to latest versions #332

wants to merge 9 commits into from

Conversation

Jacalz
Copy link
Contributor

@Jacalz Jacalz commented Mar 5, 2022

This modernizes the imported packages a lot by updating to the latest releases. It should bring many improvements and a fix for #318. The protobuf package should probably be updated to "google.golang.org/protobuf/proto" but this is at least better than before.

@ohaeusler
Copy link

Thank you @Jacalz I've forked your fork and created a release for myself, which im using until @nhooyr answers.

@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 7, 2022

Cool @ohaeusler. There is another option if you don’t want to carry fork through. If you update the above packages inside your own module instead, they will be added as indirect dependencies and overwrite what this project uses (for that specific module) :)

@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 17, 2022

@nhooyr Any chance that you'd be able to review this?

@ryanchristo
Copy link

Any updates on this? Mainly concerned about GHSA-h395-qcrw-5vmq.

@Jacalz
Copy link
Contributor Author

Jacalz commented Aug 15, 2022

Until this repository is maintained, I will continue to update the dependencies in https://github.com/rymdport/websocket. However, I have enough on my plate already and can not guarantee any bug fixes or features being implemented.

@nhooyr
Copy link
Owner

nhooyr commented Mar 7, 2023

I cannot merge this in due to other pending changes. I'm going to be removing all of these dependencies from the test code and move the tests that use them into a separate module. See #297

@nhooyr nhooyr closed this Mar 7, 2023
@nhooyr
Copy link
Owner

nhooyr commented Mar 7, 2023

Though thank you for your work @Jacalz and sorry I've been unresponsive.

@Jacalz Jacalz deleted the master branch March 7, 2023 15:11
@Jacalz
Copy link
Contributor Author

Jacalz commented Mar 7, 2023

@nhooyr It's great to see you being active again. I'll go ahead and delete my fork once you have implemented those changes (and has the project entirely up and running again) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants