Skip to content

Commit

Permalink
Update dependencies Jan 2023 (#1000)
Browse files Browse the repository at this point in the history
# Pull Request

## 🤨 Rationale

Updates our dependencies and devDependencies for all packages. The
intention is to not introduce any breaking changes and relying on tests
+ storybook for that.

Also adds a size to the storybook landing page image to fix #943 (we are
on the latest MDX2 now which is what changed for StoryBook 7 so I don't
think it's gonna change anything else related to MDX significantly).

Updates to the latest Angular 14 (but not up to 15).
Does not update TypeScript past 4.6:
- upgrading to 4.7 isn't required by anything and all our existing apps
are on 4.6, so didn't seem worth including in this PR. Maybe a follow-up
if it works without errors. Typescript 4.7 is needed for package
[import/export
support](https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-7.html#packagejson-exports-imports-and-self-referencing).
- upgrading to 4.8 is desired as it is the minimum required by Angular
15 but is not supported by fast:
microsoft/fast#6365
- upgrading to 4.9 is not supported by Angular 14, Angular 15.1 is the
[first version to support
4.9](angular/angular@dd42974)

## 👩‍💻 Implementation

Result of `npm outdated` after changes:
```
Package                                  Current         Wanted         Latest  Location                                        Depended by
@angular-devkit/build-angular            14.2.10        14.2.10         15.1.3  node_modules/@angular-devkit/build-angular      angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/animations                      14.2.12        14.2.12         15.1.2  node_modules/@angular/animations                angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/cli                             14.2.10        14.2.10         15.1.3  node_modules/@angular/cli                       angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/common                          14.2.12        14.2.12         15.1.2  node_modules/@angular/common                    angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/common                          14.2.12        14.2.12         15.1.2  node_modules/@angular/common                    nimble-angular@npm:@ni/nimble-angular@16.0.3
@angular/compiler                        14.2.12        14.2.12         15.1.2  node_modules/@angular/compiler                  angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/compiler-cli                    14.2.12        14.2.12         15.1.2  node_modules/@angular/compiler-cli              angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/core                            14.2.12        14.2.12         15.1.2  node_modules/@angular/core                      angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/core                            14.2.12        14.2.12         15.1.2  node_modules/@angular/core                      nimble-angular@npm:@ni/nimble-angular@16.0.3
@angular/forms                           14.2.12        14.2.12         15.1.2  node_modules/@angular/forms                     angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/forms                           14.2.12        14.2.12         15.1.2  node_modules/@angular/forms                     nimble-angular@npm:@ni/nimble-angular@16.0.3
@angular/platform-browser                14.2.12        14.2.12         15.1.2  node_modules/@angular/platform-browser          angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/platform-browser-dynamic        14.2.12        14.2.12         15.1.2  node_modules/@angular/platform-browser-dynamic  angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/router                          14.2.12        14.2.12         15.1.2  node_modules/@angular/router                    angular-workspace@npm:@ni-private/angular-workspace@1.0.0
@angular/router                          14.2.12        14.2.12         15.1.2  node_modules/@angular/router                    nimble-angular@npm:@ni/nimble-angular@16.0.3
@tanstack/virtual-core             3.0.0-beta.41  3.0.0-beta.41  3.0.0-alpha.1  node_modules/@tanstack/virtual-core             nimble-components@npm:@ni/nimble-components@18.0.3
ng-packagr                                14.2.2         14.2.2         15.1.1  node_modules/ng-packagr                         angular-workspace@npm:@ni-private/angular-workspace@1.0.0
typescript                                 4.6.4          4.6.4          4.9.4  node_modules/typescript                         xliff-to-json-converter@npm:@ni/xliff-to-json-converter@1.1.0
typescript                                 4.6.4          4.6.4          4.9.4  node_modules/typescript                         nimble-tokens@npm:@ni/nimble-tokens@4.3.2
typescript                                 4.6.4          4.6.4          4.9.4  node_modules/typescript                         nimble-components@npm:@ni/nimble-components@18.0.3
typescript                                 4.6.4          4.6.4          4.9.4  node_modules/typescript                         angular-workspace@npm:@ni-private/angular-workspace@1.0.0
typescript                                 4.6.4          4.6.4          4.9.4  node_modules/typescript                         site@npm:@ni-private/site@1.0.0
zone.js                                   0.11.8         0.11.8         0.12.0  node_modules/zone.js                            angular-workspace@npm:@ni-private/angular-workspace@1.0.0
```


## 🧪 Testing

Rely on CI and chromatic

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
rajsite committed Jan 30, 2023
1 parent 474e50d commit e1da136
Show file tree
Hide file tree
Showing 73 changed files with 15,580 additions and 20,008 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,12 @@ jobs:
node-version: '16'
registry-url: 'https://registry.npmjs.org'
cache: 'npm'
# Specify npm version
# See: https://github.com/actions/setup-node/issues/529
- run: npm i -g npm@8
- run: npm ci
- run: npm outdated
continue-on-error: true

# Audit
- run: npm audit --only=prod
Expand Down
22 changes: 11 additions & 11 deletions angular-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"build:library": "npm run generate-icons && ng build @ni/nimble-angular",
"build:application": "ng build example-client-app",
"generate-icons": "npm run generate-icons:bundle && npm run generate-icons:run",
"generate-icons:bundle": "rollup --config projects/ni/nimble-angular/build/generate-icons/rollup.config.js",
"generate-icons:bundle": "rollup --bundleConfigAsCjs --config projects/ni/nimble-angular/build/generate-icons/rollup.config.js",
"generate-icons:run": "node projects/ni/nimble-angular/build/generate-icons/dist/index.js",
"pack": "npm run pack:library && npm run pack:application",
"pack:library": "cd dist/ni/nimble-angular && npm pack",
Expand Down Expand Up @@ -37,24 +37,24 @@
"@angular-devkit/build-angular": "^14.2.0",
"@angular/cli": "^14.2.0",
"@angular/compiler-cli": "^14.2.0",
"@microsoft/fast-web-utilities": "^5.4.1",
"@microsoft/fast-web-utilities": "^6.0.0",
"@ni/eslint-config-angular": "^5.0.3",
"@ni/eslint-config-javascript": "^4.2.0",
"@ni/eslint-config-typescript": "^4.2.0",
"@ni/nimble-tokens": "*",
"@rollup/plugin-node-resolve": "^13.1.3",
"@types/jasmine": "^3.6.0",
"@types/node": "^12.11.1",
"eslint-plugin-jsdoc": "^37.9.7",
"jasmine-core": "^3.7.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@types/jasmine": "^4.3.1",
"@types/node": "^18.11.18",
"eslint-plugin-jsdoc": "^39.6.8",
"jasmine-core": "^4.5.0",
"karma": "^6.3.0",
"karma-chrome-launcher": "^3.1.0",
"karma-coverage": "^2.0.3",
"karma-jasmine": "^4.0.0",
"karma-jasmine-html-reporter": "^1.5.0",
"karma-jasmine": "^5.1.0",
"karma-jasmine-html-reporter": "^2.0.0",
"ng-packagr": "^14.1.0",
"puppeteer": "^10.1.0",
"rollup": "^2.61.1",
"puppeteer": "^19.6.0",
"rollup": "^3.10.1",
"typescript": "~4.6.4"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Nimble dependencies updated to latest",
"packageName": "@ni/nimble-blazor",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Nimble dependencies updated to latest",
"packageName": "@ni/nimble-components",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Nimble dependencies updated to latest",
"packageName": "@ni/nimble-tokens",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Dev Dependencies updated to latest",
"packageName": "@ni/xliff-to-json-converter",
"email": "rajsite@users.noreply.github.com",
"dependentChangeType": "none"
}

0 comments on commit e1da136

Please sign in to comment.