Angular 15 upgrade #1655

mollykreis · 2023-11-07T22:20:36Z

Pull Request

🤨 Rationale

Update to Angular 15.2 for nimble-angular.

Resolves #1079
Resolves #1017
Resolves #1570
Resolves #732
Resolves #1665

👩‍💻 Implementation

Update Angular version to 15.2 using Angular's upgrade utility
Create forks of some of Angular's CVAs and Angular's RouterLink directive under angular-workspace\projects\ni\nimble-angular\src\thirdparty\directives\ with modifications to get them to work as expected as base classes for nimble directives
Add explicit dependency on source-map-loader to nimble-components to ensure the tests continue to run as they previously did

🧪 Testing

Ran the Angular app and verified it worked as expected
Existing unit tests pass
Copied & adapted Angular tests for CVAs and RouterLink directive into angular-workspace\projects\ni\nimble-angular\src\thirdparty\directives\tests\
Added new unit tests for each nimble CVA that verifies that ngModelChange is only called once when a control's value changes
Added new unit tests for each routerLink directive that verifies that the href was sanitized
Used the built package to verify it works correctly in SystemLinkShared

✅ Checklist

I have updated the project documentation to reflect my changes or determined no changes are needed.

…l copy

…nd local copy of RouterLink directive

…rs are run twice

…o angular-15-upgrade

mollykreis · 2023-11-08T16:16:19Z

@m-akinc, can you buddy these changes for me?

.../ni/nimble-angular/src/directives/anchor-base/disableable-router-link-with-href.directive.ts

...lar/src/directives/breadcrumb-item/nimble-breadcrumb-item-router-link-with-href.directive.ts

...angular/src/directives/number-field/tests/nimble-number-field-control-value-accessor.spec.ts

angular-workspace/projects/ni/nimble-angular/src/thirdparty/utils/coercion.ts

package-lock.json

change/@ni-nimble-components-f628da4e-838f-45bf-9e54-469aa8273f75.json

...lar-workspace/projects/ni/nimble-angular/src/thirdparty/directives/control_value_accessor.ts

angular-workspace/projects/ni/nimble-angular/src/thirdparty/directives/router_link.ts

…rectives/router_link.ts Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>

...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts

angular-workspace/projects/ni/nimble-angular/src/thirdparty/testing/browser_util.ts

angular-workspace/projects/ni/nimble-angular/src/thirdparty/testing/matchers.ts

angular-workspace/projects/ni/nimble-angular/src/thirdparty/testing/matchers.d.ts

angular-workspace/projects/ni/nimble-angular/src/thirdparty/README.md

mollykreis and others added 27 commits October 24, 2023 14:27

Automatic upgrade to Angular 15

8a170cb

Update peer dependencies

11c2e12

Copy Angular directives into thirdparty directory and extend the loca…

1d49001

…l copy

Ensure all tests run

0546c38

Fix NimbleBreadcrumbItemRouterLinkWithHrefDirective to correctly exte…

7aa992c

…nd local copy of RouterLink directive

Remove providers from copied providers to fix bug where change handle…

ac310e0

…rs are run twice

Change files

f9ee67c

format

416a814

correct peer dependencies in package-lock

2df568a

add explicit dependency on source-map-loader

ecf59db

Change files

939d10b

RouterLink tests

1ac2fc1

Merge branch 'main' into angular-15-upgrade

6ee1b89

DisableableRouterLinkWithHrefDirective extends local copy of RouterLink

9986d3e

Update package-lock.json

745c74f

router_link tests

0d5a6a5

add tests for ngModelChange being fired a single time

9dfae0a

Remove debugger

4039fdc

Merge branch 'angular-15-upgrade' of https://github.com/ni/nimble int…

3b35210

…o angular-15-upgrade

a few more [Nimble] comments

4aac73e

Control Value Accessor tests

87d2f23

remove fdescribe

1f6435b

modifications to router link integration tests

f5f3509

Rename integration.spec.ts to make it more clear what it is testing

79f4f72

Merge branch 'main' into angular-15-upgrade

fb3f2e4

Updates to modification summaries

e4eaf23

Merge branch 'main' into angular-15-upgrade

075bf87

mollykreis requested a review from m-akinc November 8, 2023 16:16

m-akinc approved these changes Nov 8, 2023

View reviewed changes

atmgrifter00 approved these changes Nov 13, 2023

View reviewed changes

PR feedback

573ead7

rajsite reviewed Nov 15, 2023

View reviewed changes

...lar-workspace/projects/ni/nimble-angular/src/thirdparty/directives/control_value_accessor.ts Outdated Show resolved Hide resolved

rajsite approved these changes Nov 15, 2023

View reviewed changes

mollykreis added 3 commits November 16, 2023 09:04

PR feedback

bdf84a0

Merge branch 'main' into angular-15-upgrade

33bab00

Update package-lock.json

c8fe467

rajsite reviewed Nov 16, 2023

View reviewed changes

angular-workspace/projects/ni/nimble-angular/src/thirdparty/directives/router_link.ts Outdated Show resolved Hide resolved

mollykreis and others added 4 commits November 16, 2023 15:43

Update nimble-breadcrumb-item-router-link-with-href.directive.ts

b8a66e0

Update angular-workspace/projects/ni/nimble-angular/src/thirdparty/di…

18e9a6a

…rectives/router_link.ts Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>

Reference Angular sanitization docs

4acbb02

Update radio_control_value_accessor.ts to 15.2

df156ee

m-akinc reviewed Nov 17, 2023

View reviewed changes

...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts Outdated Show resolved Hide resolved

m-akinc linked an issue Nov 17, 2023 that may be closed by this pull request

Update all forked Angular directives to be based on Angular 15 #1665

Closed

jattasNI mentioned this pull request Nov 22, 2023

ngModelChange fires twice when the value for nimble-text-field is updated #1017

Closed

Merge branch 'main' into angular-15-upgrade

7ffe70c