Include copy of Angular RadioControlValueAccessor and dependencies #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
requested changes
Oct 19, 2022
...ce/projects/ni/nimble-angular/src/directives/radio/radio-control-value-accessor.directive.ts
Outdated
Show resolved
Hide resolved
...ce/projects/ni/nimble-angular/src/directives/radio/radio-control-value-accessor.directive.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Oct 19, 2022
rajsite
requested changes
Oct 19, 2022
rajsite
reviewed
Oct 19, 2022
...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Oct 19, 2022
angular-workspace/projects/ni/nimble-angular/src/thirdparty/directives/ng_control.ts
Outdated
Show resolved
Hide resolved
rajsite
requested changes
Oct 19, 2022
...lar-workspace/projects/ni/nimble-angular/src/thirdparty/directives/control_value_accessor.ts
Show resolved
Hide resolved
...lar-workspace/projects/ni/nimble-angular/src/thirdparty/directives/control_value_accessor.ts
Show resolved
Hide resolved
...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Oct 19, 2022
...rkspace/projects/ni/nimble-angular/src/thirdparty/directives/radio_control_value_accessor.ts
Outdated
Show resolved
Hide resolved
rajsite
reviewed
Oct 19, 2022
…rectives/radio_control_value_accessor.ts Co-authored-by: Milan Raj <rajsite@users.noreply.github.com>
rajsite
approved these changes
Oct 20, 2022
atmgrifter00
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Fixes #782
👩💻 Implementation
Copied several types from the Angular source base into the Nimble repo, including:
We're pulling in version 14.2.6 since we will soon be upgrading Nimble's version of Angular. To make it work with version 12 in the meantime, I made one small change to an error reporting function to throw an Error rather than a RuntimeError. Throwing an Error is what it did in version 12.
🧪 Testing
Unit tests still pass
✅ Checklist