Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI, vulnerability checking, and dependencies. #129

Merged
merged 1 commit into from
Sep 15, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .snyk
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
version: v1
11 changes: 7 additions & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
language: node_js
node_js:
- stable
- 4.2
- 0.10
- 0.12
- "node"
- "iojs"
- "6.0"
- "5.0"
- "4.2"
- "0.12"
- "0.10"
script: make test-coveralls
sudo: false
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#node-coveralls

[![Build Status][travis-image]][travis-url] [![Coverage Status][coveralls-image]][coveralls-url] [![Codeship Build Status][codeship-image]][codeship-url]
[![Known Vulnerabilities](https://snyk.io/test/github/nickmerwin/node-coveralls/badge.svg)](https://snyk.io/test/github/nickmerwin/node-coveralls)

[Coveralls.io](https://coveralls.io/) support for node.js. Get the great coverage reporting of coveralls.io and add a cool coverage button ( like the one above ) to your README.

Expand Down
28 changes: 15 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"url": "https://github.com/nickmerwin/node-coveralls/issues"
},
"scripts": {
"test": "make test"
"test": "snyk test && make test"
},
"bin": {
"coveralls": "./bin/coveralls.js"
Expand All @@ -26,22 +26,24 @@
"elliotcable <github@elliottcable.name> (http://elliottcable.name/)",
"Slotos <slotos@gmail.com> (http://slotos.net)",
"mattjmorrison <mattjmorrison@mattjmorrison.com> (http://mattjmorrison.com)",
"Arpad Borsos <arpad.borsos@googlemail.com> (http://swatinem.de/)"
"Arpad Borsos <arpad.borsos@googlemail.com> (http://swatinem.de/)",
"Adam Moss (https://github.com/adam-moss)"
],
"dependencies": {
"js-yaml": "3.0.1",
"lcov-parse": "0.0.6",
"log-driver": "1.2.4",
"request": "2.69.0",
"minimist": "1.2.0"
"js-yaml": "3.6.1",
"lcov-parse": "0.0.10",
"log-driver": "1.2.5",
"minimist": "1.2.0",
"request": "2.73.0"
},
"devDependencies": {
"sinon-restore": "1.0.0",
"mocha-lcov-reporter": "0.0.1",
"mocha": "1.8.1",
"should": "1.1.0",
"istanbul": "0.2.10",
"jshint": "2.1.3"
"istanbul": "0.4.4",
"jshint": "2.9.2",
"mocha": "2.5.3",
"mocha-lcov-reporter": "1.2.0",
"should": "9.0.2",
"sinon-restore": "1.0.1",
"snyk": "1.17.0"
},
"engines": {
"node": ">=0.8.6"
Expand Down
8 changes: 4 additions & 4 deletions test/fetchGitData.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,14 +98,14 @@ describe("fetchGitData", function(){
"covert": "to a string"
}
}, function(err, str){
str.branch.should.be.a("string");
str.branch.should.be.String();
fetchGitData({
"head": {
"id": "COMMIT_HASH"
},
"branch": ["convert", "to", "a", "string"]
}, function(err, str){
str.branch.should.be.a("string");
str.branch.should.be.String();
done();
});
});
Expand Down Expand Up @@ -168,11 +168,11 @@ describe("fetchGitData", function(){
process.env.COVERALLS_GIT_BRANCH = "master";
getOptions(function(err, options){
options = options.git;
options.head.should.be.a("object");
options.head.should.be.Object();
options.head.author_name.should.not.equal("Unknown Author");
options.head.committer_name.should.not.equal("Unknown Committer");
options.head.message.should.not.equal("Unknown Commit Message");
options.branch.should.be.a("string");
options.branch.should.be.String();
options.should.have.property("remotes");
options.remotes.should.be.instanceof(Array);
options.remotes.length.should.be.above(0);
Expand Down
2 changes: 1 addition & 1 deletion test/getOptions.js
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ var testGitBranchDetection = function(sut, done){
if (localGit.branch)
options.git.branch.should.equal(localGit.branch);
else
options.git.should.not.have.property('branch');
options.git.should.not.have.key('branch');
localGit.wrapUp();
done();
});
Expand Down