Implement ignoreFunctionLength assumption (babel#12491)

packages/babel-core/src/config/validation/options.js

@@ -332,6 +332,7 @@ type EnvPath = $ReadOnly<{
 export type NestingPath = RootPath | OverridesPath | EnvPath;
 
 export const assumptionsNames = new Set<string>([
+  "ignoreFunctionLength",
   "ignoreToPrimitiveHint",
   "mutableTemplateObject",
   "setClassMethods",

packages/babel-plugin-proposal-object-rest-spread/src/index.js

@@ -23,6 +23,9 @@ export default declare((api, opts) => {
     throw new Error(".loose must be a boolean, or undefined");
   }
 
+  const ignoreFunctionLength =
+    api.assumption("ignoreFunctionLength") ?? opts.loose;
+
   function getExtendsHelper(file) {
     return useBuiltIns
       ? t.memberExpression(t.identifier("Object"), t.identifier("assign"))
@@ -275,7 +278,7 @@ export default declare((api, opts) => {
             idx >= i - 1 || paramsWithRestElement.has(idx);
           convertFunctionParams(
             path,
-            loose,
+            ignoreFunctionLength,
             shouldTransformParam,
             replaceRestElement,
           );

packages/babel-plugin-proposal-object-rest-spread/test/fixtures/assumption-ignoreFunctionLength/options.json

@@ -0,0 +1,8 @@
+{
+  "plugins": [
+    "proposal-object-rest-spread"
+  ],
+  "assumptions": {
+    "ignoreFunctionLength": true
+  }
+}

packages/babel-plugin-proposal-object-rest-spread/test/fixtures/assumption-ignoreFunctionLength/parameters-object-rest-used-in-default/input.js

@@ -0,0 +1,3 @@
+({...R}, a = R) => {}
+({...R}, e, c = 2, a = R, f = q) => { let q; }
+({...R}, a = f(R)) => {}

packages/babel-plugin-proposal-object-rest-spread/test/fixtures/assumption-ignoreFunctionLength/parameters-object-rest-used-in-default/output.js

@@ -0,0 +1,33 @@
+function _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }
+
+(_ref, a) => {
+  let R = _extends({}, _ref);
+
+  if (a === void 0) {
+    a = R;
+  }
+};
+
+(_ref2, e, c = 2, a, f) => {
+  let R = _extends({}, _ref2);
+
+  if (a === void 0) {
+    a = R;
+  }
+
+  if (f === void 0) {
+    f = q;
+  }
+
+  return function () {
+    let q;
+  }();
+};
+
+(_ref3, a) => {
+  let R = _extends({}, _ref3);
+
+  if (a === void 0) {
+    a = f(R);
+  }
+};

packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-spread-loose/parameters-object-rest-used-in-default/input.js

@@ -0,0 +1,3 @@
+({...R}, a = R) => {}
+({...R}, e, c = 2, a = R, f = q) => { let q; }
+({...R}, a = f(R)) => {}

packages/babel-plugin-proposal-object-rest-spread/test/fixtures/object-spread-loose/parameters-object-rest-used-in-default/output.js

@@ -0,0 +1,33 @@
+function _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }
+
+(_ref, a) => {
+  let R = _extends({}, _ref);
+
+  if (a === void 0) {
+    a = R;
+  }
+};
+
+(_ref2, e, c = 2, a, f) => {
+  let R = _extends({}, _ref2);
+
+  if (a === void 0) {
+    a = R;
+  }
+
+  if (f === void 0) {
+    f = q;
+  }
+
+  return function () {
+    let q;
+  }();
+};
+
+(_ref3, a) => {
+  let R = _extends({}, _ref3);
+
+  if (a === void 0) {
+    a = f(R);
+  }
+};

packages/babel-plugin-transform-parameters/src/index.js

@@ -6,7 +6,9 @@ export { convertFunctionParams };
 export default declare((api, options) => {
   api.assertVersion(7);
 
-  const { loose } = options;
+  const ignoreFunctionLength =
+    api.assumption("ignoreFunctionLength") ?? options.loose;
+
   return {
     name: "transform-parameters",
 
@@ -23,7 +25,10 @@ export default declare((api, options) => {
         }
 
         const convertedRest = convertFunctionRest(path);
-        const convertedParams = convertFunctionParams(path, loose);
+        const convertedParams = convertFunctionParams(
+          path,
+          ignoreFunctionLength,
+        );
 
         if (convertedRest || convertedParams) {
           // Manually reprocess this scope to ensure that the moved params are updated.

packages/babel-plugin-transform-parameters/src/params.js

@@ -44,7 +44,7 @@ const iifeVisitor = {
 // last 2 parameters are optional -- they are used by proposal-object-rest-spread/src/index.js
 export default function convertFunctionParams(
   path,
-  loose,
+  ignoreFunctionLength,
   shouldTransformParam,
   replaceRestElement,
 ) {
@@ -123,7 +123,10 @@ export default function convertFunctionParams(
     }
 
     const paramIsAssignmentPattern = param.isAssignmentPattern();
-    if (paramIsAssignmentPattern && (loose || node.kind === "set")) {
+    if (
+      paramIsAssignmentPattern &&
+      (ignoreFunctionLength || node.kind === "set")
+    ) {
       const left = param.get("left");
       const right = param.get("right");
 

packages/babel-plugin-transform-parameters/test/fixtures/use-loose-option/options.json → packages/babel-plugin-transform-parameters/test/fixtures/assumption-ignoreFunctionLength/options.json

@@ -3,12 +3,14 @@
     "proposal-class-properties",
     "external-helpers",
     "syntax-flow",
-    ["transform-parameters", { "loose": true }],
+    "transform-parameters",
     "transform-block-scoping",
     "transform-spread",
     "transform-classes",
     "transform-destructuring",
-    "transform-arrow-functions",
-    "transform-for-of"
-  ]
+    "transform-arrow-functions"
+  ],
+  "assumptions": {
+    "ignoreFunctionLength": true
+  }
 }

packages/babel-plugin-transform-parameters/test/fixtures/loose/ignoreFunctionLength/input.js

@@ -0,0 +1,3 @@
+function fn(a, b = c()) {
+  return b;
+}

packages/babel-plugin-transform-parameters/test/fixtures/loose/ignoreFunctionLength/output.js

@@ -0,0 +1,7 @@
+function fn(a, b) {
+  if (b === void 0) {
+    b = c();
+  }
+
+  return b;
+}

packages/babel-plugin-transform-parameters/test/fixtures/loose/options.json

@@ -0,0 +1,5 @@
+{
+  "plugins": [
+    ["transform-parameters", { "loose": true }]
+  ]
+}