Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: partial attribute completion #140

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luckasRanarison
Copy link

@luckasRanarison luckasRanarison commented Mar 15, 2024

Currently attribute completion only works when being at the beginning of an attribute list or after a comma and need to be triggered manually after inserting [ or after , . Being able to autocomplete attribute when starting to type the attribute name itself would be really convinnient.
For example, the following case doesn't get autocomplete:

digraph {
  start -> end [sha|]
                // ^ cursor here
}

This is an attempt to solve that problem but I'm stuck on the above case, the current node is TextIdentifier and the previous node kind type is AttributeContainer but this is also the case in the following situation (#17):

digraph {
  start -> end [color=blue]
  s|
// ^ cursor here
}

So we don't have enough context... I'd be happy to hear your thoughts on this.

@nikeee
Copy link
Owner

nikeee commented Apr 2, 2024

I added some CI and formatting checks to master and updated this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants