Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service/mail header and recover from service panic #695

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

heilmela
Copy link

@heilmela heilmela commented Sep 16, 2023

Description

Used Postmark with service/mail. Postmark uses the X-PM-Message-Stream header to select a message stream via header. Currently its not possible to set headers.
Furthermore the service/mail did panic when encountering some missing TLS port issues, which leads to waiting for the service routines call to hang until context deadline, which might be undesirable in some cases.

I would suggest adding the recover and error handle for the corresponding service. I know recovering is debatable but the hanging because of one service seems undesirable.

@nikoksr wdyt ?

How Has This Been Tested?

  • Added a test for the new addHeader
  • setup postmark transactional stream
  • send some emails

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant