Add service/mail header and recover from service panic #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Used Postmark with service/mail. Postmark uses the
X-PM-Message-Stream
header to select a message stream via header. Currently its not possible to set headers.Furthermore the service/mail did panic when encountering some missing TLS port issues, which leads to waiting for the service routines call to hang until context deadline, which might be undesirable in some cases.
I would suggest adding the recover and error handle for the corresponding service. I know recovering is debatable but the hanging because of one service seems undesirable.
@nikoksr wdyt ?
How Has This Been Tested?
Types of changes
Checklist: