Improve types

niksy · Dec 8, 2021 · 06f8a8e · 06f8a8e
1 parent d5eb876
commit 06f8a8e
Showing 1 changed file with 16 additions and 5 deletions.
diff --git a/helpers/rollup/plugin.js b/helpers/rollup/plugin.js
@@ -1,6 +1,14 @@
 'use strict';
 
-function handleCircularDependancyWarning(warning, rollupWarn) {
+/**
+ * @typedef {import('rollup')} rollup
+ * @typedef {import('rollup').WarningHandlerWithDefault} rollup.WarningHandlerWithDefault
+ */
+
+/**
+ * @type {rollup.WarningHandlerWithDefault}
+ */
+function handleCircularDependancyWarning(warning, warningHandler) {
 	const packagesWithCircularDependencies = [
 		'util/',
 		'assert/',
@@ -10,12 +18,15 @@ function handleCircularDependancyWarning(warning, rollupWarn) {
 	if (
 		!(
 			warning.code === 'CIRCULAR_DEPENDENCY' &&
-			packagesWithCircularDependencies.some((modulePath) =>
-				warning.importer.includes(modulePath)
-			)
+			packagesWithCircularDependencies.some((modulePath) => {
+				if (typeof warning.importer !== 'string') {
+					return false;
+				}
+				return warning.importer.includes(modulePath);
+			})
 		)
 	) {
-		rollupWarn(warning);
+		warningHandler(warning);
 	}
 }