crypto: exit potentially infinite loop in GetLastIssuedCert if stuck

Fixes: nodejs#37757 Refs: nodejs#37889
nils91 · Mar 31, 2021 · d93dcf2 · d93dcf2
1 parent 01d8b39
commit d93dcf2
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/crypto/crypto_common.cc b/src/crypto/crypto_common.cc
@@ -480,8 +480,17 @@ MaybeLocal<Object> GetLastIssuedCert(
       return MaybeLocal<Object>();
     issuer_chain = ca_info;
 
+    // Take the value of cert->get() before and after the call to cert->reset()
+    // in order to compare them and provide a way to exit this loop
+    // in case it gets stuck
+    X509* value_before_reset = cert->get();
+
     // Delete previous cert and continue aggregating issuers.
     cert->reset(ca);
+
+    X509* value_after_reset = cert->get();
+    if (value_before_reset == value_after_reset)
+      break;
   }
   return MaybeLocal<Object>(issuer_chain);
 }