whitelist generic params matching typedesc for templates/macros
#23438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metagn
added a commit
to metagn/Nim
that referenced
this pull request
Mar 25, 2024
|
Wrote description, CI failure is probably unrelated |
metagn
force-pushed
the
macro-generic-param-typedesc
branch
from
ab43e50
to
c007bf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #23432
After #22029 generic parameter types no longer match
typedescparameters in overloading, as this previously instantiated procs with an unresolved type as atypedescvalue. However macros and templates don't use the same mechanism for generic instantiation, cannot delay their instantiations further than the point that they get compiled (i.e. are generically instantiated) and can inspect types more precisely anyway, so for practicality purposes we can whitelist them fortypedescand keep old code working.If whitelisting macros and templates isn't sufficient (i.e. in cases where
c.calleeSymis nil) we can also blacklist runtime routines (c.calleeSym != nil and c.calleeSym.kind in (routineKinds - {skMacro, skTemplate})).