WIP: Adding support for docker property in project.yml #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set up bats test framework to run shell-script based tests. Started ported internal tests to public repo. Re-wrote tests to ensure no side-effects.
Fixing small errors when running all tests together.
Having a single repos means if the deploy stage fails one runtime - it breaks all the other tests. This is not ideal.
- Add empty dir to incremental test - Use templated diff for directory - Remove unnecessary package.json info
Calculate correct 'kind' value when docker property is present.
Added unit tests for this new feature and set up the testing pipeline.
project.yml now supports the following:
```yaml
packages:
- name: default
actions:
- name: hello
main: 'main'
docker: 'us.gcr.io/nimgcp/actionloop-python-v3.7ai'
```
|
We've now got a new version of the OpenWhisk Client JS available which unblocks this PR BUT the deployer code is now in a separate repo: https://github.com/nimbella/nimbella-deployer. I'll need to move these changes over there.... |
jthomas
added a commit
to nimbella/nimbella-deployer
that referenced
this pull request
Jun 7, 2021
|
This has now been done in nimbella/nimbella-deployer@fb9c21f |
|
oh nice 🎉 - might need an example in the docs? i'm not sure how to use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is an example of what this would look like:
The code changes were very simple but I've taken the chance to setup unit testing for the deployer code and add this into the build pipeline. Going forward - we'll want to keep adding unit tests for new features.
This is a WIP as the OpenWhisk type for "Exec" is missing the
mainproperty. I'm going to fix that upstream so we can merge this. The tests currently have to use a temporary// @ts-ignoreto build and run locally.In terms of testing - I have run the unit tests for this new feature, run the deployer tests and deployed a sample project using the YAML definition above. All works so far.