Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented 'start_pool_if_missing' logic #295

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

umbec
Copy link

@umbec umbec commented May 27, 2022

Hi @essen!

I have this patch that expands the start_pool_if_missing logic, allocating a new pool on demand.

If a pool for a certain authority already exists, the checkout process succeed, and the request goes on as always.
In the other case, a new pool is allocated with the opts() passed to the start_pool_if_missing flag.

This code has been working on my services for a while, and without the presumption of being perfect or to address all the open points in the pool management, it can brings an useful improvement to the current implementation.

If you have any objection or suggestion to the implementation, let me know.

@essen
Copy link
Member

essen commented May 27, 2022

Thanks! I will have to review and that will take a while as I'm in the middle of a very heavy set of changes. But the initial feeling is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants