Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Finalize deprecations #1117

Merged
merged 2 commits into from Jun 18, 2022

Conversation

effigies
Copy link
Member

Forgot to test before release that DeprecationWarnings were promoted to ExpiredDeprecationErrors. Will fix this and release 4.0.1.

@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1117 (d1b66c5) into maint/4.0.x (e042875) will increase coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           maint/4.0.x    #1117   +/-   ##
============================================
  Coverage        91.75%   91.76%           
============================================
  Files              101      101           
  Lines            12380    12380           
  Branches          2423     2423           
============================================
+ Hits             11359    11360    +1     
+ Misses             694      693    -1     
  Partials           327      327           
Impacted Files Coverage Δ
nibabel/gifti/gifti.py 86.47% <0.00%> (-1.48%) ⬇️
nibabel/viewers.py 96.14% <0.00%> (+0.64%) ⬆️
nibabel/freesurfer/mghformat.py 92.93% <0.00%> (+1.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e042875...d1b66c5. Read the comment docs.

@effigies
Copy link
Member Author

Pre-release failures are related to numpy/numpy#21437. Will address separately.

@effigies effigies merged commit b8854c3 into nipy:maint/4.0.x Jun 18, 2022
@effigies effigies deleted the test/finalize_deprecations branch June 18, 2022 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant