TEST: Suppress new numpy warning on nan-to-int cast #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## maint/4.0.x #1118 +/- ##
============================================
Coverage 91.76% 91.76%
============================================
Files 101 101
Lines 12380 12380
Branches 2423 2423
============================================
Hits 11360 11360
Misses 693 693
Partials 327 327 Continue to review full report at Codecov.
|
effigies
force-pushed
the
test/numpy_1.24-dev
branch
from
a72a1b6
to
4e77024
Compare
|
Sorry - I didn't check - but our pre-release checks will hit the relevant branch? |
Relevant branch of numpy? Yes, that commit is in nightly, which is why pre-release tests are failing right now. Not sure if I'm interpreting correctly, though, so please feel free to clarify your question. |
|
Yes, sorry - that's what I meant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
numpy/numpy#21437 does not require us to change our behavior, but does require us to change our expectations of what warnings are raised. Since this is quite an edge case, it seems to make more sense to suppress the warning and eventually expect it when numpy 1.24 becomes our minimum.
@matthew-brett What do you think?